Fix DDP unused param error when TE is enabled in NeMo Lite #11364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onur Yilmaz <[email protected]>
ananthsub
reviewed
Nov 22, 2024
| if self.model_accelerator == "te": | ||
| from nemo.lightning.pytorch.accelerate.transformer_engine import te_accelerate | ||
|
|
||
| te_accelerate(self.model, fp8_autocast=False) |
There was a problem hiding this comment.
how do you intend other settings like fp8 autocast to be specified?
There was a problem hiding this comment.
Good question. I guess I should change that to a parameter class.
There was a problem hiding this comment.
Ok, change it to partial function as @akoumpa suggested.
akoumpa
reviewed
Nov 22, 2024
examples/llm/sft/hf.py
Outdated
| @@ -75,17 +75,9 @@ def squad(tokenizer) -> pl.LightningDataModule: | |||
| grad_clip = None | |||
| use_dist_samp = False | |||
|
|
|||
| model = llm.HfAutoModelForCausalLM(args.model) | |||
| model = llm.HfAutoModelForCausalLM(model_name=args.model, model_accelerator=args.model_accelerator) | |||
There was a problem hiding this comment.
can we pass a partial function instead?
There was a problem hiding this comment.
I also thought about it but I am just not sure how it'll look from the user perspective.
Signed-off-by: Onur Yilmaz <[email protected]>
Signed-off-by: oyilmaz-nvidia <[email protected]>
|
beep boop 🤖: 🙏 The following files have warnings. In case you are familiar with these, please try helping us to improve the code base. Your code was analyzed with PyLint. The following annotations have been identified: Thank you for improving NeMo's documentation! |
akoumpa
approved these changes
Nov 22, 2024
|
[🤖]: Hi @oyilmaz-nvidia 👋, We wanted to let you know that a CICD pipeline for this PR just finished successfully So it might be time to merge this PR or get some approvals I'm just a bot so I'll leave it you what to do next. //cc @pablo-garay @ko3n1g |
ananthsub
pushed a commit
to ananthsub/NeMo
that referenced
this pull request
Nov 25, 2024
) * Fix DDP unused param error when TE is enabled Signed-off-by: Onur Yilmaz <[email protected]> * Added partial function for te Signed-off-by: Onur Yilmaz <[email protected]> * Apply isort and black reformatting Signed-off-by: oyilmaz-nvidia <[email protected]> --------- Signed-off-by: Onur Yilmaz <[email protected]> Signed-off-by: oyilmaz-nvidia <[email protected]> Co-authored-by: oyilmaz-nvidia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Fixed DDP issue with TE